Annotation tools#2024
Annotation tools#2024danielcebrian wants to merge 6 commits intoopenedx:masterfrom danielcebrian:master
Conversation
cms/templates/base.html
Outdated
There was a problem hiding this comment.
All of these scripts need to be loaded via require.js, instead of via <script> tags.
There was a problem hiding this comment.
First of all, happy new year 2014
Thank you very much for reviewing the code
I going to answer all your reviews.
I do not know how to use Require.js. As soon as possible I will try to use this library, and make a new pull
|
This pull request is going to need a lot of cleanup before it's ready to go in: probably some major refactoring to account for things like internationalization, modular, testable Javascript, RESTful URL routing, and so on. I also don't see any tests whatsoever. |
|
@danielcebrian Can this PR be rebased? At the moment it can't be merged (and a clean rebase will make reviewing easier) |
|
@danielcebrian FYI if you're unfamiliar about rebasing, see https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request and feel free to ask us. |
|
@jtauber and @danielcebrian: Reviewing from a testeng perspective: this PR currently has 13% unit test coverage on lines of python code changed. We cannot merge in changes to the student and notes djangoapps or new xmodules (textannotation_module and videoannotation_module) that have no unit tests. Also the changes to the StudentNotes class in notes.coffee should be covered by a Jasmine test. |
|
@jzoldak yep, they are working on it. Luis just sent an email to the edx-code google group (subject "Testing Xmodule Question") asking for some help on a particular point. |
|
Awesome. I can help out Luis, no problem. |
|
Thank you to all for your help and evaluation. |
…nosis_generate_csv openedx#2023 openedx#2024 (openedx#2049) * Add command ga_diagnosis_send_data openedx#2023 * Add report email feature to ga_diagnosis_generate_csv command openedx#2024
7 participants
Here is the first round of annotation tools for the platform. Included are Text and Video annotation modules along with the My Notes page module that aggregates all annotations.